Skip to content

Fix profile_gtest.bin SIGABRT caused by use-after-destroy of t2MarkersMutex #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+8 −0
Closed

Fix profile_gtest.bin SIGABRT caused by use-after-destroy of t2MarkersMutex #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cb81ae
Initial plan
Copilot Mar 26, 2026
b017e7f
Fix profile_gtest.bin crash: reinitialize T2 marker component map aft…
Copilot Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions source/test/bulkdata/profileTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,14 @@ TEST_F(ProfileTest, ClearMarkerComponentMapShouldRemoveEntries) {

EXPECT_EQ(Vector_Size(eventComponentList), 0);
EXPECT_EQ(destroyT2MarkerComponentMap(), T2ERROR_SUCCESS);
// Reinitialize for subsequent tests that depend on marker component map
EXPECT_CALL(*g_vectorMock, Vector_Create(_))
.Times(::testing::AtMost(1))
.WillRepeatedly(Return(T2ERROR_SUCCESS));
EXPECT_CALL(*g_vectorMock, Vector_Destroy(_, _))
.Times(::testing::AtMost(1))
.WillRepeatedly(Return(T2ERROR_SUCCESS));
EXPECT_EQ(initT2MarkerComponentMap(), T2ERROR_SUCCESS);
Comment on lines 509 to +517
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling initT2MarkerComponentMap() here can double-initialize internal static mutexes (e.g., t2CompListMutex is pthread_mutex_init()'d in initT2MarkerComponentMap() but is never pthread_mutex_destroy()'d in destroyT2MarkerComponentMap()). This is undefined behavior and can lead to flaky crashes or EBUSY failures. A safer test-only fix would be to avoid destroyT2MarkerComponentMap() in this test (it’s not needed to validate clear semantics), or move init/destroy into a suite-level SetUpTestSuite/TearDownTestSuite so init runs once and destroy runs once at the end.

Suggested change
EXPECT_EQ(destroyT2MarkerComponentMap(), T2ERROR_SUCCESS);
// Reinitialize for subsequent tests that depend on marker component map
EXPECT_CALL(*g_vectorMock, Vector_Create(_))
.Times(::testing::AtMost(1))
.WillRepeatedly(Return(T2ERROR_SUCCESS));
EXPECT_CALL(*g_vectorMock, Vector_Destroy(_, _))
.Times(::testing::AtMost(1))
.WillRepeatedly(Return(T2ERROR_SUCCESS));
EXPECT_EQ(initT2MarkerComponentMap(), T2ERROR_SUCCESS);

Copilot uses AI. Check for mistakes.
}

#endif
Expand Down
Loading