Skip to content

BES1-941: Increase Process name buffer length from 16 to 64 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogeswaransky wants to merge 2 commits into
base: support/1.8.5
Choose a base branch
from
+32 −32
Open

BES1-941: Increase Process name buffer length from 16 to 64 #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36cc492
BES1-941: Update dcautil.h
yogeswaransky Apr 1, 2026
5ed035d
Update dcaproc.c
yogeswaransky Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions source/dcautil/dcaproc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@

int getProcUsage(char *processName, TopMarker* marker, char* filename)
{
T2Debug("%s ++in \n", __FUNCTION__);
T2Info("%s ++in \n", __FUNCTION__);
if(marker == NULL || processName == NULL)
{
T2Error("Invalid arguments for getProcUsage\n");
return -1;
}
if(processName != NULL)
{
T2Debug("Process name is %s \n", processName);
T2Info("Process name is %s \n", processName);
procMemCpuInfo pInfo;
char pidofCommand[PIDOF_SIZE];
#if defined (ENABLE_PS_PROCESS_SEARCH)
Expand All @@ -96,7 +96,7 @@ int getProcUsage(char *processName, TopMarker* marker, char* filename)
memset(&pInfo, '\0', sizeof(procMemCpuInfo));
memcpy(pInfo.processName, processName, strlen(processName) + 1);

T2Debug("Command for collecting process info : \n pidof %s", processName);
T2Info("Command for collecting process info : \n pidof %s", processName);
#ifdef LIBSYSWRAPPER_BUILD
cmdPid = v_secure_popen("r", "pidof %s", processName);
#else
Expand All @@ -105,7 +105,7 @@ int getProcUsage(char *processName, TopMarker* marker, char* filename)
#endif
if(!cmdPid)
{
T2Debug("Failed to execute %s", pidofCommand);
T2Info("Failed to execute %s", pidofCommand);
return 0;
}
pid = (int *) malloc(sizeof(pid_t));
Expand All @@ -118,7 +118,7 @@ int getProcUsage(char *processName, TopMarker* marker, char* filename)
#endif
if(pclose_ret != 0)
{
T2Debug("failed in closing pipe! ret %d\n", pclose_ret);
T2Info("failed in closing pipe! ret %d\n", pclose_ret);
}
return 0;
}
Expand All @@ -144,7 +144,7 @@ int getProcUsage(char *processName, TopMarker* marker, char* filename)
#endif
if(pclose_ret != 0)
{
T2Debug("failed in closing pipe! ret %d\n", pclose_ret);
T2Info("failed in closing pipe! ret %d\n", pclose_ret);
}
return 0;
}
Expand All @@ -159,7 +159,7 @@ int getProcUsage(char *processName, TopMarker* marker, char* filename)
#endif
if(pclose_ret != 0)
{
T2Debug("failed in closing pipe! ret %d\n", pclose_ret);
T2Info("failed in closing pipe! ret %d\n", pclose_ret);
}

#if defined (ENABLE_PS_PROCESS_SEARCH)
Expand Down Expand Up @@ -228,7 +228,7 @@ int getProcUsage(char *processName, TopMarker* marker, char* filename)
pInfo.pid = pid;
if(0 != getProcInfo(&pInfo, filename))
{
T2Debug("Process info - CPU: %s, Memory: %s \n", pInfo.cpuUse, pInfo.memUse);
T2Info("Process info - CPU: %s, Memory: %s \n", pInfo.cpuUse, pInfo.memUse);

if (marker->cpuValue)
{
Expand Down Expand Up @@ -256,7 +256,7 @@ int getProcUsage(char *processName, TopMarker* marker, char* filename)
free(pid);
}
}
T2Debug("%s --out \n", __FUNCTION__);
T2Info("%s --out \n", __FUNCTION__);
return 0;
}

Expand All @@ -273,7 +273,7 @@ int getProcUsage(char *processName, TopMarker* marker, char* filename)
*/
int getProcPidStat(int pid, procinfo * pinfo)
{
T2Debug("%s ++in \n", __FUNCTION__);
T2Info("%s ++in \n", __FUNCTION__);
char szFileName[CMD_LEN], szStatStr[2048], *s, *t;
int ppid, fd, pgrp, session, tty, tpgid, counter, priority, starttime, signal, blocked, sigignore, sigcatch, j;
char exName[CMD_LEN], state;
Expand All @@ -282,14 +282,14 @@ int getProcPidStat(int pid, procinfo * pinfo)

if(NULL == pinfo)
{
T2Debug("Invalid input(pinfo=NULL) to get process info");
T2Info("Invalid input(pinfo=NULL) to get process info");
return 0;
}

sprintf(szFileName, "/proc/%u/stat", (unsigned) pid);
if((fd = open(szFileName, O_RDONLY)) == -1)
{
T2Debug("Failed to open file in get process info");
T2Info("Failed to open file in get process info");
return 0;
}

Expand Down Expand Up @@ -322,7 +322,7 @@ int getProcPidStat(int pid, procinfo * pinfo)

close(fd);

T2Debug("%s --out \n", __FUNCTION__);
T2Info("%s --out \n", __FUNCTION__);

return 1;
}
Expand All @@ -336,7 +336,7 @@ int getProcPidStat(int pid, procinfo * pinfo)
*/
int getProcInfo(procMemCpuInfo *pmInfo, char* filename)
{
T2Debug("%s ++in \n", __FUNCTION__);
T2Info("%s ++in \n", __FUNCTION__);
if(0 == getMemInfo(pmInfo))
{
return 0;
Expand All @@ -360,7 +360,7 @@ int getProcInfo(procMemCpuInfo *pmInfo, char* filename)
*/
int getMemInfo(procMemCpuInfo *pmInfo)
{
T2Debug("%s ++in \n", __FUNCTION__);
T2Info("%s ++in \n", __FUNCTION__);
static char retMem[MEM_STRING_SIZE];
int intStr = 0, intValue = 0;
double residentMemory = 0.0;
Expand Down Expand Up @@ -394,7 +394,7 @@ int getMemInfo(procMemCpuInfo *pmInfo)

strncpy(pmInfo->memUse, retMem, sizeof(pmInfo->memUse) - 1);
pmInfo->memUse[sizeof(pmInfo->memUse) - 1] = '\0';
T2Debug("%s --out \n", __FUNCTION__);
T2Info("%s --out \n", __FUNCTION__);
return 1;
}

Expand All @@ -415,10 +415,10 @@ char* saveTopOutput(char* profilename)
return retfile;
}

T2Debug("%s ++in \n", __FUNCTION__);
T2Info("%s ++in \n", __FUNCTION__);
if(access(filename, F_OK) == 0)
{
T2Debug("%s --out \n", __FUNCTION__);
T2Info("%s --out \n", __FUNCTION__);
removeTopOutput(strdup(retfile));
}
int ret = 0;
Expand All @@ -437,7 +437,7 @@ char* saveTopOutput(char* profilename)
{
cmd_option = 1;
}
T2Debug("top cmd -c arg status %d, ret value %d \n", cmd_option, ret);
T2Info("top cmd -c arg status %d, ret value %d \n", cmd_option, ret);
#ifdef INTEL
/* Format Use: `top n 1 | grep Receiver` */
if ( 1 == cmd_option )
Expand All @@ -462,7 +462,7 @@ char* saveTopOutput(char* profilename)
#endif
if(ret == 0)
{
T2Debug("return value of system command to create %s is success with code\n", filename);
T2Info("return value of system command to create %s is success with code\n", filename);
}
else
{
Expand All @@ -473,14 +473,14 @@ char* saveTopOutput(char* profilename)
}
return NULL;
}
T2Debug("%s --out \n", __FUNCTION__);
T2Info("%s --out \n", __FUNCTION__);
return retfile;

}

void removeTopOutput(char* filename)
{
T2Debug("%s ++in \n", __FUNCTION__);
T2Info("%s ++in \n", __FUNCTION__);
if(filename != NULL)
{
int ret = 0;
Expand All @@ -493,14 +493,14 @@ void removeTopOutput(char* filename)
#endif
if(ret == 0)
{
T2Debug("return value of system command to remove %s is success with code %d \n", filename, ret);
T2Info("return value of system command to remove %s is success with code %d \n", filename, ret);
}
else
{
T2Error("return value of system command to remove %s is not successful with code %d \n", filename, ret);
}
free(filename);
T2Debug("%s --out \n", __FUNCTION__);
T2Info("%s --out \n", __FUNCTION__);
return;
}
}
Expand Down Expand Up @@ -541,7 +541,7 @@ int getCPUInfo(procMemCpuInfo *pInfo, char* filename)
}
if((filename != NULL) && (access(filename, F_OK) != 0))
{
T2Debug("%s ++in the savad temp log %s is not available \n", __FUNCTION__, filename);
T2Info("%s ++in the savad temp log %s is not available \n", __FUNCTION__, filename);
/* Check Whether -c option is supported */
#ifdef LIBSYSWRAPPER_BUILD
ret = v_secure_system(" top -c -n 1 2> /dev/null 1> /dev/null");
Expand Down Expand Up @@ -587,7 +587,7 @@ int getCPUInfo(procMemCpuInfo *pInfo, char* filename)
}
else
{
T2Debug("%s ++in the savad temp log %s is available \n", __FUNCTION__, filename);
T2Info("%s ++in the savad temp log %s is available \n", __FUNCTION__, filename);
#ifdef LIBSYSWRAPPER_BUILD
inFp = v_secure_popen("r", "cat %s |grep -i '%s'", TOPTEMP, pInfo->processName);
#else
Expand All @@ -600,7 +600,7 @@ int getCPUInfo(procMemCpuInfo *pInfo, char* filename)

if(!(inFp))
{
T2Debug("failed in open v_scure_popen pipe! ret %d\n", pclose_ret);
T2Info("failed in open v_scure_popen pipe! ret %d\n", pclose_ret);
return 0;
}

Expand All @@ -627,7 +627,7 @@ int getCPUInfo(procMemCpuInfo *pInfo, char* filename)
#endif

snprintf(pInfo->cpuUse, sizeof(pInfo->cpuUse), "%.1lf", (float)(total_cpu_usage / normalize));
T2Debug("calculated CPU total value : %f Normalized value : %.1lf\n", total_cpu_usage, (float)(total_cpu_usage / normalize));
T2Info("calculated CPU total value : %f Normalized value : %.1lf\n", total_cpu_usage, (float)(total_cpu_usage / normalize));
#ifdef LIBSYSWRAPPER_BUILD
pclose_ret = v_secure_pclose(inFp);
#else
Expand All @@ -636,10 +636,10 @@ int getCPUInfo(procMemCpuInfo *pInfo, char* filename)

if(pclose_ret != 0)
{
T2Debug("failed in closing pipe! ret %d\n", pclose_ret);
T2Info("failed in closing pipe! ret %d\n", pclose_ret);
}
return ret;
T2Debug("--out %s", __FUNCTION__);
T2Info("--out %s", __FUNCTION__);

}

Expand Down Expand Up @@ -670,7 +670,7 @@ int getTotalCpuTimes(int * totalTime)
&a[0], &a[1], &a[2], &a[3], &a[4], &a[5], &a[6], &a[7], &a[8], &a[9]);
if(ret == -1)
{
T2Debug("%s --read error from /proc/stat \n", __FUNCTION__);
T2Info("%s --read error from /proc/stat \n", __FUNCTION__);
}

fclose(fp);
Expand Down
2 changes: 1 addition & 1 deletion source/dcautil/dcautil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void freeGResult(void *data);
T2ERROR saveGrepConfig(char *name, Vector* grepMarkerList);
T2ERROR getGrepResults(GrepSeekProfile **GSP, Vector *markerList, bool isClearSeekMap, bool check_rotated, char *customLogPath);
#define PREFIX_SIZE 5
#define BUF_LEN 16
#define BUF_LEN 64
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing BUF_LEN increases the size of fixed arrays (e.g., procMemCpuInfo.processName), but current call sites copy into these arrays using length derived from the input string (e.g., memcpy(..., strlen(processName)+1) in dcaproc.c) without bounding to BUF_LEN. This remains a potential buffer overflow if a caller passes a name longer than BUF_LEN-1. Consider switching to a bounded copy (and optionally returning an error or explicitly truncating) everywhere these buffers are written.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUF_LEN is used not only for processName but also for cpuUse and memUse in procMemCpuInfo, so this change increases those buffers as well. If the intent is strictly to increase the process name limit, consider introducing a dedicated PROCESS_NAME_LEN (leaving cpuUse/memUse unchanged) or update the PR title/description to reflect the broader impact.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are existing unit tests covering getProcInfo/getProcUsage, but none appear to validate behavior with process names longer than the previous 16-byte limit. Since this change is explicitly increasing the supported name length, add a test that exercises a >16 and <=63 character processName to ensure it’s handled safely (no overflow/truncation surprises).

Copilot generated this review using guidance from repository custom instructions.

typedef struct proc_info
{
Expand Down
Loading