Open
Conversation
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| // Just a comment |
There was a problem hiding this comment.
The added line // Just a comment is non-descriptive and adds noise at the top of the file. Please remove it or replace it with a meaningful comment that explains something specific about this module that isn’t already covered by the header/license block.
Suggested change
| // Just a comment |
| #include <string.h> | ||
| #include <unistd.h> | ||
| #include <time.h> | ||
| #include <stdatomic.h> |
There was a problem hiding this comment.
<stdatomic.h> is newly included but there are no atomic types/operations used in this file. Please drop the include to avoid unnecessary dependencies (or add the corresponding atomic usage if this was intended).
Suggested change
| #include <stdatomic.h> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.