TCXB8-3928 Observed SYS_SH_IPTableFW_restart marker during stability on TXB8 devices#276
Open
TCXB8-3928 Observed SYS_SH_IPTableFW_restart marker during stability on TXB8 devices#276
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents generating an invalid IPv4 SNAT rule in do_wan_nat_lan_clients() when natip4 is empty, addressing stability issues observed on TXB8 devices (iptables self-heal triggering on restart).
Changes:
- Added
IS_EMPTY_STRING(natip4)guard before emittingSNAT --to-source %srules in twodo_wan_nat_lan_clients()branches. - Added debug logging when
natip4is empty and the SNAT rule is skipped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue : iptable rule impacted minimally .Still It recovers post this selfheal action of restart.
rca : suspect like missing validation for natip4 NULL/empty before fprintf to prevent segmentation fault and invalid SNAT rule generation.
fix : Added missing natip4 NULL/empty check before fprintf to prevent segmentation fault and invalid SNAT rule generation.