Fixed TypeScript error with UIManager.MyViewManager.Commands.create in MyView.tsx Android Native UI Components #4172#4253
Open
muhammadashfaq wants to merge 4 commits into
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
muhammadashfaq
changed the title
UIManager.MyViewManager.Commands.create in MyView.tsx #4172UIManager.MyViewManager.Commands.create in MyView.tsx Android Native UI Components #4172
Contributor
Author
cortinico
requested changes
Oct 8, 2024
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Let's make sure the CI is green 👍
Contributor
Author
@cortinico CI is green 👍 |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title:
Fixed TypeScript error with
UIManager.MyViewManager.Commands.createin MyView.tsxDescription:
This PR addresses a TypeScript error that occurs when accessing
UIManager.MyViewManager.Commands.create.toString()inMyView.tsx. The direct reference toUIManager.MyViewManager.Commandsmay not be available or initialized properly, especially in some environments, which causes issues when working with custom native view managers.Changes:
UIManager.MyViewManager.Commands.create.toString()with the more reliableUIManager.getViewManagerConfig('MyViewManager').Commands.create.toString()to ensure that the view manager configuration is correctly fetched and initialized before using the command.This fix ensures compatibility and prevents errors when working with custom native components on both Android.
Closes issue #4172.
Testing: