Add a safeguard against incorrect Java method argument type assumption#45882
Closed
rshest wants to merge 1 commit into
Closed
Add a safeguard against incorrect Java method argument type assumption#45882rshest wants to merge 1 commit into
rshest wants to merge 1 commit into
Conversation
Summary: Adds a safeguard inside Java side marshalling of the arguments via ReadableArray - even though the majority of code do make an explicit assumption of the argument type, in practice it's not always the case. Differential Revision: D60700917
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60700917 |
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
Stale
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
Stale
Collaborator
|
Closing this PR as the diff D60700917 has been abandoned internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Adds a safeguard inside Java side marshalling of the arguments via ReadableArray - even though the majority of code do make an explicit assumption of the argument type, in practice it's not always the case.
Differential Revision: D60700917