Skip to content

fix: forward style prop to Modal inner container View #56181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnuMessi10 wants to merge 2 commits into from
Closed

fix: forward style prop to Modal inner container View #56181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad0f25d
fix: forward style prop to Modal inner container View
AnuMessi10 Mar 21, 2026
88b45be
fix: ensure transparent and backdropColor take precedence over style …
AnuMessi10 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions packages/react-native/Libraries/Modal/Modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,12 +288,16 @@ class Modal extends React.Component<ModalProps, ModalState> {
return null;
}

const containerStyles = {
backgroundColor:
this.props.transparent === true
? 'transparent'
: (this.props.backdropColor ?? 'white'),
};
// Only override backgroundColor when transparent or backdropColor are
// explicitly set, so that these Modal-specific props take precedence
// over the generic style prop. The default backgroundColor ('white')
// is defined in styles.container below.
const containerStyles = {};
if (this.props.transparent === true) {
containerStyles.backgroundColor = 'transparent';
} else if (this.props.backdropColor != null) {
containerStyles.backgroundColor = this.props.backdropColor;
}

let animationType = this.props.animationType || 'none';

Expand Down Expand Up @@ -349,7 +353,7 @@ class Modal extends React.Component<ModalProps, ModalState> {
<ScrollView.Context.Provider value={null}>
<View
// $FlowFixMe[incompatible-type]
style={[styles.container, containerStyles]}
style={[styles.container, this.props.style, containerStyles]}
collapsable={false}>
{innerChildren}
</View>
Expand Down Expand Up @@ -380,6 +384,7 @@ const styles = StyleSheet.create({
[side]: 0,
top: 0,
flex: 1,
backgroundColor: 'white',
},
});

Expand Down