Fix Yoga Style equality crash for size-typed dimensions#56429
Closed
sbuggay wants to merge 1 commit into
Closed
Conversation
Summary: Changelog: [Internal] The existing `lengthsEqual` comparator was used for `dimensions_`, `minDimensions_`, and `maxDimensions_`, but these are size-typed values stored via `StyleValuePool::getSize()`, not length-typed. Using the wrong accessor caused crashes during style equality checks. Added a `sizeLengthsEqual` helper (scalar + array overloads) that correctly calls `StyleValuePool::getSize()` and swapped it in for the three dimension fields in `Style::operator==`. Differential Revision: D100189121
meta-cla
Bot
added
the
CLA Signed
|
@sbuggay has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100189121. |
sbuggay
added a commit
to sbuggay/yoga
that referenced
this pull request
Apr 13, 2026
Summary: X-link: react/react-native#56429 Changelog: [Internal] The existing `lengthsEqual` comparator was used for `dimensions_`, `minDimensions_`, and `maxDimensions_`, but these are size-typed values stored via `StyleValuePool::getSize()`, not length-typed. Using the wrong accessor caused crashes during style equality checks. Added a `sizeLengthsEqual` helper (scalar + array overloads) that correctly calls `StyleValuePool::getSize()` and swapped it in for the three dimension fields in `Style::operator==`. Differential Revision: D100189121
meta-codesync Bot
pushed a commit
to react/yoga
that referenced
this pull request
Apr 14, 2026
Summary: Pull Request resolved: #1931 X-link: react/react-native#56429 Changelog: [Internal] The existing `lengthsEqual` comparator was used for `dimensions_`, `minDimensions_`, and `maxDimensions_`, but these are size-typed values stored via `StyleValuePool::getSize()`, not length-typed. Using the wrong accessor caused crashes during style equality checks. Added a `sizeLengthsEqual` helper (scalar + array overloads) that correctly calls `StyleValuePool::getSize()` and swapped it in for the three dimension fields in `Style::operator==`. Reviewed By: joevilches Differential Revision: D100189121 fbshipit-source-id: 284f849d01ca7d15ca34d2dcaafaa92ee9dfd59f
|
This pull request has been merged in 40c7d8f. |
Collaborator
|
This pull request was successfully merged by @sbuggay in 40c7d8f When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
The existing
lengthsEqualcomparator was used fordimensions_,minDimensions_, andmaxDimensions_, but these are size-typed values stored viaStyleValuePool::getSize(), not length-typed. Using the wrong accessor caused crashes during style equality checks.Added a
sizeLengthsEqualhelper (scalar + array overloads) that correctly callsStyleValuePool::getSize()and swapped it in for the three dimension fields inStyle::operator==.Differential Revision: D100189121