Skip to content

[#504] Keep editor bars from covering content#505

Merged
realproject7 merged 1 commit into
mainfrom
task/504-editor-footer-clearance
Jun 8, 2026
Merged

[#504] Keep editor bars from covering content#505
realproject7 merged 1 commit into
mainfrom
task/504-editor-footer-clearance

Conversation

@realproject7

Copy link
Copy Markdown
Owner

Closes #504.

Summary

  • give the right-hand story workspace a true flex-1 min-h-0 content slot so Preview/Edit pages recalculate correctly after tab and route switches
  • keep the prose editor save/status bar and the episode footer as reserved non-scrolling rows instead of letting them ride over the editor body
  • add a Genesis opening-text regression test that switches Preview/Edit/Cuts repeatedly and asserts the save bar plus footer remain mounted separately from the editor body

Verification

  • npm run typecheck
  • npm run lint -- --quiet app/web/components/StoriesPage.tsx app/web/components/PreviewPanel.tsx app/web/components/PreviewPanel.test.tsx
  • npm run app:build
  • targeted Vitest remains blocked in this environment before collection by Unknown system error -122, write, including npx vitest run --coverage.enabled=false app/web/components/PreviewPanel.test.tsx

Visual / Viewport QA Notes

  • the active right-panel view now lives inside a flex-1 min-h-0 wrapper in StoriesPage, so top workflow/nav strips and bottom publish/error strips reserve height instead of forcing the editor to overrun the column
  • the plain prose editor shell in PreviewPanel is now overflow-hidden with a dedicated non-shrinking save/status row, and the bottom episode footer is also a non-shrinking sibling with its own background
  • Genesis opening-text regression coverage switches Preview -> Edit -> Cuts -> Opening text -> Preview twice and asserts both the editor save bar and the footer remain present as separate chrome

Risks

  • this changes the shared right-column flex stack for every story workspace, so any regression would most likely appear in other full-height story pages that depended on the old implicit h-full sizing
  • the fix is layout-structural rather than route-specific, so follow-up visual review should still spot-check Whitepaper and future episode prose editors in addition to Genesis opening text

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I reviewed PR #505 on live head 768afb765819498ad6eac9b0a95ee9bf1ac65a08. The fix matches issue #504: the story workspace now allocates a real flex-1 min-h-0 slot for the active panel, and the prose editor save bar plus bottom footer are rendered as reserved rows instead of overlaying the editor body.

Findings

  • No blocking findings.

Decision

Approved on GitHub. The structural layout changes in StoriesPage and PreviewPanel are scoped to the right-hand story workspace, and the new Genesis regression test exercises the reported Preview -> Edit -> Cuts -> Opening text -> Preview switching path. Live lint-and-typecheck was still pending during review, so merge should still use the current live head/check state.

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

PR #505 fixes the reported cartoon prose-editor overlap by giving the right workspace and PreviewPanel editor a proper min-h-0 flex stack, keeping the save/status bar and bottom footer as non-shrinking rows outside the editor scroll body. The added regression test exercises the Genesis opening-text Edit/Cuts/Preview switching path that triggered the bug.

Findings

  • No blocking findings.

Decision

Approved on GitHub for commit 768afb765819498ad6eac9b0a95ee9bf1ac65a08. Live lint-and-typecheck passes, and the implementation is scoped to the affected cartoon/right-panel layout plus rebuilt dist artifacts.

@realproject7 realproject7 merged commit aa32b52 into main Jun 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cartoon bug: edit save/status bar can overlay and hide document content

2 participants