#501 Simplify focused lettering editor into canvas-first mode#510
Conversation
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I reviewed PR #510 on the current live head. The change matches issue #501: the focused lettering editor is now more canvas-first, with the old explanatory chrome collapsed into a compact toolbar/help pattern and the inspector prioritizing active overlay controls.
Findings
- No blocking findings.
Decision
Approved. The focused editor now starts with one compact toolbar row containing status chips plus the required Back to cut review / Show work area controls, the long guide copy moves behind Help, the inspector surfaces selected-overlay controls before helper/script guidance, and the cut-review AI action is renamed to AI draft bubbles while the focused editor still treats AI-generated overlays as editable draft state rather than a prompt-copy primary path. Live lint-and-typecheck was still pending at review time, so merge should still use the current live head/check state.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I reviewed PR #510 on live head 6dcc7cbecb0682e2ac6e5d3c514365101fbb48d3. The change matches issue #501 by moving the Focused Lettering Editor toward a compact canvas-first toolbar, demoting explanatory copy, and preserving editable AI-drafted overlays.
Findings
- No blocking findings.
Decision
Approved on GitHub. The focused editor now exposes Back to cut review, Show work area, status chips, and Help without the old prose/checklist stack; selected-overlay controls lead the inspector before script insertion; and the cut card action is now AI draft bubbles while still opening editable draft overlays. Live lint-and-typecheck passes.
Summary
AI draft bubbles, keeping the result as editable draft overlays in the focused editorTesting
npm run typechecknpm run lint -- --quiet app/web/components/LetteringEditor.tsx app/web/components/LetteringEditor.test.tsx app/web/components/CutListPanel.tsx app/web/components/CutListPanel.test.tsxnpm run app:buildnpx vitest run --coverage.enabled=false app/web/components/LetteringEditor.test.tsx app/web/components/CutListPanel.test.tsx(fails before collection in this environment withUnknown system error -122, write)Visual QA
1440x900: the focused editor canvas starts materially higher because the old prose header and separate checklist row are gone; the top chrome is now one compact toolbar row with chips instead of stacked guidance1728x1195: selected-overlay controls remain visible earlier in the inspector because helper text and script insertion are demoted below the active controls or behind HelpAI draft bubbles, and the resulting draft still opens as editable overlays in the focused editorRisks