Skip to content

#501 Simplify focused lettering editor into canvas-first mode#510

Merged
realproject7 merged 1 commit into
mainfrom
task/501-canvas-first-lettering-editor
Jun 8, 2026
Merged

#501 Simplify focused lettering editor into canvas-first mode#510
realproject7 merged 1 commit into
mainfrom
task/501-canvas-first-lettering-editor

Conversation

@realproject7

Copy link
Copy Markdown
Owner

Summary

  • compress the focused lettering editor into a compact canvas-first toolbar with status chips, help disclosure, and the required review/work-area controls
  • move explanatory copy out of the primary toolbar and prioritize selected-overlay inspector controls over helper guidance
  • rename the full-review AI entry point to AI draft bubbles, keeping the result as editable draft overlays in the focused editor

Testing

  • npm run typecheck
  • npm run lint -- --quiet app/web/components/LetteringEditor.tsx app/web/components/LetteringEditor.test.tsx app/web/components/CutListPanel.tsx app/web/components/CutListPanel.test.tsx
  • npm run app:build
  • npx vitest run --coverage.enabled=false app/web/components/LetteringEditor.test.tsx app/web/components/CutListPanel.test.tsx (fails before collection in this environment with Unknown system error -122, write)

Visual QA

  • 1440x900: the focused editor canvas starts materially higher because the old prose header and separate checklist row are gone; the top chrome is now one compact toolbar row with chips instead of stacked guidance
  • 1728x1195: selected-overlay controls remain visible earlier in the inspector because helper text and script insertion are demoted below the active controls or behind Help
  • the cut review card now exposes AI draft bubbles, and the resulting draft still opens as editable overlays in the focused editor

Risks

  • the toolbar now wraps more controls into one compact row, so regressions would show up as awkward wrapping on narrower widths or missed button visibility
  • the inspector helper/script sections now move depending on whether an overlay is selected, so regressions would most likely show up as missing script insertion affordances after selection

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I reviewed PR #510 on the current live head. The change matches issue #501: the focused lettering editor is now more canvas-first, with the old explanatory chrome collapsed into a compact toolbar/help pattern and the inspector prioritizing active overlay controls.

Findings

  • No blocking findings.

Decision

Approved. The focused editor now starts with one compact toolbar row containing status chips plus the required Back to cut review / Show work area controls, the long guide copy moves behind Help, the inspector surfaces selected-overlay controls before helper/script guidance, and the cut-review AI action is renamed to AI draft bubbles while the focused editor still treats AI-generated overlays as editable draft state rather than a prompt-copy primary path. Live lint-and-typecheck was still pending at review time, so merge should still use the current live head/check state.

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

I reviewed PR #510 on live head 6dcc7cbecb0682e2ac6e5d3c514365101fbb48d3. The change matches issue #501 by moving the Focused Lettering Editor toward a compact canvas-first toolbar, demoting explanatory copy, and preserving editable AI-drafted overlays.

Findings

  • No blocking findings.

Decision

Approved on GitHub. The focused editor now exposes Back to cut review, Show work area, status chips, and Help without the old prose/checklist stack; selected-overlay controls lead the inspector before script insertion; and the cut card action is now AI draft bubbles while still opening editable draft overlays. Live lint-and-typecheck passes.

@realproject7 realproject7 merged commit 3a8512f into main Jun 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants