Skip to content

[#1299] Document T2.4b hybrid SQL helper pattern#1313

Merged
realproject7 merged 1 commit into
mainfrom
task/1299-sql-helper-docs
May 26, 2026
Merged

[#1299] Document T2.4b hybrid SQL helper pattern#1313
realproject7 merged 1 commit into
mainfrom
task/1299-sql-helper-docs

Conversation

@realproject7

Copy link
Copy Markdown
Owner

Summary

Documents the actual T2.4b implementation in docs/airdrop-contracts.md:

  • Hybrid pattern: TS wrapper (weightedSpendQuery) for config injection + Postgres function (weighted_spend) as canonical SQL
  • Explains why this is better than pure option A (no SQL string drift) or pure option B (no DB config table)

Doc-only change, no code modifications.

Closes #1299

🤖 Generated with Claude Code

Add weighted spend SQL helper section to airdrop-contracts.md
explaining the hybrid implementation: TS wrapper for config
injection + Postgres function as canonical SQL definition.

Closes #1299

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented May 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored May 26, 2026 2:51pm

Request Review

@realproject7 realproject7 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@re2 review — APPROVE ✅

Doc-only: 10 lines added to docs/airdrop-contracts.md accurately describing the T2.4b hybrid pattern (TS config wrapper + DB function). Explains why this is better than pure A or B. No code changes.

Matches #1299 acceptance criteria. No issues found.

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The docs/airdrop-contracts.md addition accurately describes the T2.4b hybrid pattern. One acceptance item from #1299 is still missing: a clarifying comment on #1241.

Findings

  • [medium] Missing #1241 clarification comment required by #1299 acceptance.

    • File: docs/airdrop-contracts.md:47
    • Suggestion: Post a comment on issue #1241 explaining that the actual implementation is hybrid: weightedSpendQuery(config) injects TS config parameters while weighted_spend(...) in supabase/migrations/00041_weighted_spend_function.sql remains the canonical SQL function. Include a link to this PR or the docs section.
  • [low] CI is still pending for PR #1313.

    • File: .github/workflows/ci.yml
    • Suggestion: Let lint-and-typecheck and e2e finish green before merge.

Decision

Request changes. The docs change itself looks good, but the explicit #1241 comment acceptance item needs to be completed.

@project7-interns project7-interns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The docs accurately describe the T2.4b hybrid implementation: TS config injection through weightedSpendQuery(config) plus the canonical weighted_spend(...) DB function. The required #1241 clarification comment has also been posted.

Findings

  • None.

Decision

Approve. CI is green for lint/typecheck and E2E on run 26455843197.

@realproject7 realproject7 merged commit 131f3a1 into main May 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[T2.9] Documentation: T2.4b implementation is hybrid (TS wrapper + DB function), not pure option A

2 participants