perf: use bit shifts for power-of-two formatting#565
Merged
prestwich merged 2 commits intorecmo:mainfrom Feb 12, 2026
Merged
Conversation
Merging this PR will improve performance by ×7.7
Performance Changes
Comparing 
|
DaniPopes
force-pushed
the
dani/fmt-pow2-fast-paths
branch
3 times, most recently
from
edd7b13 to
b72377b
Compare
gakonst
approved these changes
Feb 12, 2026
DaniPopes
force-pushed
the
dani/fmt-pow2-fast-paths
branch
from
b72377b to
0951194
Compare
DaniPopes
force-pushed
the
dani/fmt-pow2-fast-paths
branch
from
0951194 to
d7e0bd7
Compare
gakonst
approved these changes
Feb 12, 2026
prestwich
reviewed
Feb 12, 2026
| } | ||
| } | ||
|
|
||
| impl_fmt!(fmt::Display; base::Decimal, ""); |
Collaborator
There was a problem hiding this comment.
this is now the only invocation of this macro. should it still be a macro?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.