Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix sensitive data leak in telemetry logs#22

Open
jhweb wants to merge 1 commit intomainfrom
sentinel/fix-telemetry-leak-15599549885254155288
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix sensitive data leak in telemetry logs#22
jhweb wants to merge 1 commit intomainfrom
sentinel/fix-telemetry-leak-15599549885254155288

Conversation

@jhweb
Copy link
Copy Markdown
Collaborator

@jhweb jhweb commented May 5, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Sensitive data (API keys, absolute home directory paths) was being leaked into the markdown debug reports (.logs/braindrain_debug_report_*.md) when passed in the context argument of log_error.
🎯 Impact: Exposure of user credentials and system paths in plain-text log files.
πŸ”§ Fix: Implemented a recursive _sanitize_data helper in TelemetrySession that redacts sensitive patterns from strings, dictionaries, and lists. Updated log_error to use this helper for all logged data.
βœ… Verification: Verified using a reproduction script that confirmed both absolute paths and API keys are now redacted in the debug reports. Ran existing test suite to ensure no regressions.


PR created automatically by Jules for task 15599549885254155288 started by @jhweb

- Implement recursive `_sanitize_data` in `TelemetrySession` to redact absolute paths and API keys.
- Update `log_error` to sanitize both error message and context dictionary.
- Expand redaction patterns to include common API key formats (sk-, gsk_, hf_).
- Sanitize absolute paths for both macOS and Linux.

Co-authored-by: jhweb <12529192+jhweb@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant