π‘οΈ Sentinel: [MEDIUM] Enhance telemetry sanitization#25
π‘οΈ Sentinel: [MEDIUM] Enhance telemetry sanitization#25
Conversation
- Implement recursive `_sanitize_data` in `TelemetrySession` to redact paths and API keys. - Update `log_error` to sanitize both error messages and context. - Add comprehensive tests for telemetry sanitization. - Update sentinel journal with regex refinement learnings. Co-authored-by: jhweb <12529192+jhweb@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: Potential leakage of absolute system paths (PII) and sensitive API keys (OpenAI, Anthropic, Groq, HuggingFace) in telemetry logs and debug reports.
π― Impact: Exposure of internal system structure and potential compromise of third-party AI services.
π§ Fix: Implemented a robust, recursive
_sanitize_datamethod inTelemetrySessionand applied it to all error logging paths.β Verification: Added a new test suite
tests/test_security_telemetry.pythat validates redaction of paths and keys from strings and nested data structures. Verified all tests pass.PR created automatically by Jules for task 4855203436363497681 started by @jhweb