fix(ci): pin GitHub Actions to commit SHAs#2188
Conversation
Pin unpinned action tag references to full commit SHAs, fixing the GitHub Actions SHA pinning CI check which fails on both main and rhoai-3.4. - google-github-actions/run-gemini-cli@v0 -> @f77273f4... (v0.1.22) - actions/checkout@v4 -> @34e11487... (v4.3.1) [4 occurrences] - repo-sync/pull-request@v2 -> @7e79a9f5... (v2.12.1) Generated with: pinact run Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughTwo GitHub Actions workflows are updated to pin their action dependencies to specific commit SHAs instead of using moving semantic version tags. This ensures reproducible CI runs by locking action versions against unintended updates. ChangesGitHub Actions Version Pinning
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/notebook-digest-updater.yaml (1)
32-32: Consider aligningactions/checkoutversion with other workflows in this repository.This file pins
actions/checkoutto34e114876b0b11c390a56381ad16ebd13914f8d5(v4.3.1) at lines 32, 64, 159, and 236, whilenotebooks-digest-updater.yamlandsec-scan.ymlboth usede0fac2e4500dabe0009e67214ff5f5447ce83dd(v6.0.2). Since the file is already being updated for SHA pinning, consolidating on the newer version would reduce inconsistency across workflows with minimal effort.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/notebook-digest-updater.yaml at line 32, Replace the pinned actions/checkout SHA used in this workflow: find the occurrences of "uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5" and update them to the newer SHA "de0fac2e4500dabe0009e67214ff5f5447ce83dd" (v6.0.2) so the workflow aligns with the other repository workflows; ensure you change every instance in the file (all occurrences of the actions/checkout pin) to the new SHA.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/notebook-digest-updater.yaml:
- Line 32: Replace the pinned actions/checkout SHA used in this workflow: find
the occurrences of "uses:
actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5" and update them to
the newer SHA "de0fac2e4500dabe0009e67214ff5f5447ce83dd" (v6.0.2) so the
workflow aligns with the other repository workflows; ensure you change every
instance in the file (all occurrences of the actions/checkout pin) to the new
SHA.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 6f94b083-15cd-4954-9928-ab3934b1da85
📒 Files selected for processing (2)
.github/workflows/gemini-pr-review.yml.github/workflows/notebook-digest-updater.yaml
Description
Pin unpinned action tag references to full commit SHAs in two downstream-only workflow files, fixing the
GitHub Actions SHA pinningCI check which fails on bothmainandrhoai-3.4.These files (
gemini-pr-review.yml,notebook-digest-updater.yaml) do not exist inopendatahub-io/notebooks, so this fix must go directly intorhds/notebooks.Changes
gemini-pr-review.yml:161google-github-actions/run-gemini-cli@v0@f77273f4...(v0.1.22)notebook-digest-updater.yaml:32,64,159,236actions/checkout@v4@34e11487...(v4.3.1)notebook-digest-updater.yaml:239repo-sync/pull-request@v2@7e79a9f5...(v2.12.1)Generated with
pinact run.How Has This Been Tested?
pinact run --checkpasses locallySelf checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria:
Made with Cursor