WIP: Add NVMeoF CSI driver support via provider RPC#629
Conversation
Add NVMeoF CSI driver deployment following the existing NFS pattern: - Add NvmeofDriverRequirements to StorageClient status - Store NVMeoF requirements from provider RPC response - Create/delete csi.ceph.io/v1 Driver CR for NVMeoF - Add NvmeofDriverName constant to CSI templates This enables the client-operator to deploy the NVMeoF CSI driver when the provider signals availability via the GetDesiredClientState RPC. Signed-off-by: Oded Viner <oviner@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: OdedViner The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
OdedViner
changed the title
| if err := c.delete(nvmeofDriver); err != nil { | ||
| return fmt.Errorf("failed to delete csi nvmeof driver: %v", err) | ||
| } |
There was a problem hiding this comment.
Can we delete the nvmeofdriver if there exist pv/pvc using the driver?
| enableRbdDriver := c.shouldEnableDriver(enableRbdDriverKey) | ||
| enableCephFsDriver := c.shouldEnableDriver(enableCephFsDriverKey) | ||
| enableNfsDriver := c.shouldEnableDriver(enableNfsDriverKey) | ||
| enableNvmeofDriver := false |
There was a problem hiding this comment.
Could we follow the same mechanism used for other drivers?
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
Add NVMeoF CSI driver deployment following the existing NFS pattern:
This enables the client-operator to deploy the NVMeoF CSI driver when the provider signals availability via the GetDesiredClientState RPC.
Depends on #3943