Open
Conversation
'make tests' runs a single unit test of the header spec parser/matcher.
Also ensure that a bad parse fails the mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is not a way currently to send user-defined headers when a file is PUT to the object store. Most notably, Content-Type can't be controlled and is instead guessed at the server or sent as application/octet-stream, which can break static web sites hosted on CDN. Currently, CloudFiles supports 14 headers to modify CDN behavior, but cloudfuse has no mechanism for making use of these headers.
A header specification is a mount option that can send (or omit) any number of user-defined headers, based on matches (or non-matches) on the path name. The specification looks like:
For example:
See the README for more details. Unit tests are included via a new 'make tests' target. Thanks for considering accepting these changes.