Skip to content

Conversation

@Naveena-058
Copy link
Contributor

For 1.19.0 build, Pull Ginkgo test cases from argocd-operator repo and integrate them into gitops-operator test structure
What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
This PR pulls additional Ginkgo test cases from the argocd-operator repository and integrates them into the gitops-operator test structure to improve test coverage for the 1.19.0 build.

Key changes include:

  • Added new Ginkgo test files for comprehensive E2E testing:
    • 1-046_validate_application_tracking_test.go - Validates application tracking functionality
    • 1-122_validate_image_updater_test.go - Tests image updater capabilities
    • 1-051_validate_argocd_agent_principal_test.go - Tests ArgoCD agent principal validation
  • Updated existing test files:
    • Enhanced fixture utilities in fixtureUtils.go
    • Improved restricted PSS compliant test coverage
  • Ensured 1-098_validate_dex_clientsecret_deprecated.go properly uses deprecated v1alpha1 API for backwards compatibility testing

@openshift-ci openshift-ci bot requested review from chetan-rns and jannfis November 20, 2025 08:31
@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

Hi @Naveena-058. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@varshab1210
Copy link
Member

/ok-to-test

@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-parallel

@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-sequential

2 similar comments
@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-sequential

@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-sequential

@Naveena-058
Copy link
Contributor Author

/retest

@Naveena-058
Copy link
Contributor Author

/test v4.14-e2e

@Naveena-058
Copy link
Contributor Author

/test v4.19-e2e

@Naveena-058
Copy link
Contributor Author

Naveena-058 commented Nov 26, 2025

/test v4.14-kuttl-sequential

1 similar comment
@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential

@Naveena-058
Copy link
Contributor Author

/retest-required

@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-parallel

@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-sequential

@Naveena-058 Naveena-058 force-pushed the pull-ginkgo-tests-from-argocd-operator branch from 8c70a65 to 97c5c67 Compare November 27, 2025 10:33
@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-sequential

@varshab1210
Copy link
Member

/test v4.14-kuttl-sequential

/test v4.14-kuttl-parallel

@Naveena-058 Naveena-058 force-pushed the pull-ginkgo-tests-from-argocd-operator branch from 9a7e5e3 to 8eb1194 Compare December 16, 2025 11:50
@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential
/test v4.14-kuttl-parallel
/test v4.19-kuttl-sequential
/test v4.19-kuttl-parallel

@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential
/test v4.19-kuttl-sequential

@varshab1210
Copy link
Member

/test v4.14-kuttl-sequential

1 similar comment
@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential

@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential
/test v4.19-kuttl-sequential

@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-sequential

1 similar comment
@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-sequential

@Naveena-058
Copy link
Contributor Author

/test v4.19-kuttl-sequential
/test v4.14-kuttl-sequential

@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential
/test v4.19-kuttl-sequential

2 similar comments
@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential
/test v4.19-kuttl-sequential

@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential
/test v4.19-kuttl-sequential

@Naveena-058 Naveena-058 marked this pull request as ready for review January 15, 2026 17:18
@openshift-ci openshift-ci bot requested review from anandrkskd and svghadi January 15, 2026 17:18
@Naveena-058
Copy link
Contributor Author

/test v4.14-e2e
/test v4.14-kuttl-sequential
/test v4.14-kuttl-parallel
/test v4.19-images
/test v4.19-kuttl-sequential

@Naveena-058 Naveena-058 force-pushed the pull-ginkgo-tests-from-argocd-operator branch 2 times, most recently from 38e00f8 to cd311e6 Compare January 19, 2026 10:42
@Naveena-058 Naveena-058 force-pushed the pull-ginkgo-tests-from-argocd-operator branch from 469f7f8 to ded3662 Compare January 19, 2026 11:06
Signed-off-by: NAVEENA S <nas@redhat.com>
@Naveena-058 Naveena-058 force-pushed the pull-ginkgo-tests-from-argocd-operator branch from ded3662 to b5382de Compare January 19, 2026 11:07
@Naveena-058
Copy link
Contributor Author

/test v4.14-kuttl-sequential
/test v4.14-kuttl-parallel

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2026

@Naveena-058: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.19-kuttl-parallel b5382de link true /test v4.19-kuttl-parallel
ci/prow/v4.19-e2e b5382de link true /test v4.19-e2e
ci/prow/v4.14-kuttl-parallel b5382de link true /test v4.14-kuttl-parallel
ci/prow/v4.19-kuttl-sequential b5382de link true /test v4.19-kuttl-sequential
ci/prow/v4.14-kuttl-sequential b5382de link true /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Naveena-058
Copy link
Contributor Author

/test v4.19-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants