Use yaml package for formatting#1222
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Mar 27, 2026
Merged
Conversation
This replaces Prettier as the LSP formatting solution with the `yaml` package. The `yaml` package can format YAML just fine, and we already have it as a dependency. Prettier is a big dependency. If people want to use Prettier, other Prettier integrations are probably better suited for them. For example, the YAML language server doesn’t respect Prettier configuration files. This is a proof of concept. I tried to map existing options to the new implementation. A more ideal solution might be to change the formatting options. Refs redhat-developer#933
datho7561
force-pushed
the
replace-prettier
branch
from
0600e00 to
c62ade6
Compare
shin19991207
approved these changes
Mar 27, 2026
Member
shin19991207
left a comment
shin19991207
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks, David!
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rebases #983
Original text from that issue:
This replaces Prettier as the LSP formatting solution with the
yamlpackage. Theyamlpackage can format YAML just fine, and we already have it as a dependency. Prettier is a big dependency.If people want to use Prettier, other Prettier integrations are probably better suited for them. For example, the YAML language server doesn’t respect Prettier configuration files.
This is a proof of concept. I tried to map existing options to the new implementation. A more ideal solution might be to change the formatting options.
What issues does this PR fix or reference?
Refs #933 , Rebases #983
Is it tested? How?
Existing tests