Base k8s schema resolution off of GroupVersionKind#1223
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Apr 8, 2026
Merged
Base k8s schema resolution off of GroupVersionKind#1223datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
Contributor
Author
|
I looked into removing the custom validation and completion logic for files marked as "kubernetes", but that caused problems in files that don't have a GVK declared yet. We'll need a more robust solution some time in the future for this pain point; I don't think it's worth modifying the completion/validation behaviour just to get this one schema working as expected (it's a hack). It might be interesting to have a generic "kubernetes object" schema to fall back on that includes the bare minimum (completion/validation for GVK and some metadata) so that we don't have to use the large "every kubernetes object" schema. |
This should improve validation and completion of Kubernetes resources drastically. Fixes redhat-developer#1213 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
improve-k8s-schema-resolution
branch
from
b998e03 to
fa161f3
Compare
shin19991207
approved these changes
Apr 8, 2026
Member
shin19991207
left a comment
shin19991207
left a comment
There was a problem hiding this comment.
Looks good and works well for me. Thanks, David!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This should improve validation and completion of Kubernetes resources drastically.
What issues does this PR fix or reference?
Fixes #1213
Is it tested? How?