Allow to skip channels parameter in realtime profiles just by changing variables config.#511
Open
CZerta wants to merge 1 commit intoredhat-performance:masterfrom
Conversation
…g variables config. Related: rhbz#2148990 Signed-off-by: Jan Zerdik <jzerdik@redhat.com>
yarda
requested changes
Mar 8, 2023
Contributor
yarda
left a comment
yarda
left a comment
There was a problem hiding this comment.
Maybe we shouldn't complicate it. What about dropping the function check_net_queue_count and adding its functionality to the plugin_net?
It could work the way if there is e.g. the special value 'auto', then calculate it. And also change the realtime profiles appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: rhbz#2148990