oss-standalone-redisearch-m5: port parca-agent config from m7#158
Open
paulorsousa wants to merge 1 commit into
Open
oss-standalone-redisearch-m5: port parca-agent config from m7#158paulorsousa wants to merge 1 commit into
paulorsousa wants to merge 1 commit into
Conversation
The m5 cloud-init only set `remote-store-bearer-token`; with a `psc_v1_<secret>_<id>` token (no project id embedded in the JWT claims), parca-agent v0.47+ silently drops profiles unless a `--remote-store-grpc-headers=projectID=<id>` is also set. That is why redislabsdev/RediSearch benchmark dispatches against this setup produce 0 profile samples in the redisearch Polar Signals project. This change makes m5 match the m7 module: * Add `parca_agent_project_id` and `parca_agent_snap_channel` vars (defaults preserve current behaviour: empty project id, `stable` channel — so existing callers passing only the token still work). * Thread the new vars through the `templatefile` call. * Rewrite the cloud-init to mirror m7: relabel_configs file pinning to `redis-server` and promoting thread/pid labels, plus the `remote-store-grpc-headers=projectID=...` snap setting and the channel pin. Result: oss-standalone dispatches with `enable_parca_agent=true` and a `psc_v1_*` token will emit profiles to the configured Polar Signals project, with `test_name`/`git_hash`/etc labels. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the
oss-standalone-redisearch-m7parca-agent cloud-init + variables to theoss-standalone-redisearch-m5module so dispatches that pick the m5 setup also emit profiles to Polar Signals.Root cause
The m5
cloud-init-parca-agent.yamlonly set:With a
psc_v1_<secret>_<projectId>style token (no project binding inside the token claims) and parca-agent v0.47+, the agent requires:…or every profile is silently dropped at the remote-store. The m7 module already has this. Dispatching
Run RediSearch Benchmarksagainstredislabsdev/RediSearchwithallowed_setup=oss-standalone(which picks m5) produces 0 profile samples in the configured Polar Signals project despiteenable_parca_agent=trueand the agent showing as active on the bench-server.Change
m5 now mirrors m7:
variables.tf: addparca_agent_project_id(default"") +parca_agent_snap_channel(default"stable"). Defaults preserve current behaviour for callers that only pass the token.db-resources.tf: thread both new vars through thetemplatefilecall.cloud-init-parca-agent.yaml: replace the truncated install/snap-set block with the full m7 version — relabel_configs file (__meta_process_executable_namekeep-on-redis-server, thread/pid label promotion,roledefault), theremote-store-grpc-headers=projectID=…snap setting, and the channel pin soparca_agent_snap_channel: edgepicks up v0.47.1+.After this lands, a
redislabsdev/RediSearchdispatch withallowed_setup=oss-standalonewill produce per-test profiles in Polar Signals labeled with the sametest_name/git_hashset the m7 module already emits.Test plan
Run RediSearch Benchmarksworkflow onredislabsdev/RediSearchwithallowed_setup=oss-standalone,enable_parca_agent=true, validparca_agent_project_idgit_hashlabel value matching the dispatched SHA appears in Polar Signals (project73d7b9ec-…)test_namefilter narrows samples to a single test as expectedrelabel_configskeeps onlyredis-serversamples (no agent / runtime noise)🤖 Generated with Claude Code