Skip to content

Updating INCREX command arg - SATURATE now controls overflow behaviour#4077

Merged
petyaslavova merged 5 commits into
masterfrom
ps_update_increx_args
May 27, 2026
Merged

Updating INCREX command arg - SATURATE now controls overflow behaviour#4077
petyaslavova merged 5 commits into
masterfrom
ps_update_increx_args

Conversation

@petyaslavova
Copy link
Copy Markdown
Collaborator

@petyaslavova petyaslavova commented May 22, 2026

Description of change

Please provide a description of the change here.

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.


Note

Medium Risk
Public API change on increx (breaking for overflow= callers) and different error vs return behavior on bound violations; otherwise test and CI wiring.

Overview
increx is aligned with the updated Redis command: the overflow string option (FAIL / REJECT / SAT) is replaced by a boolean saturate that emits the SATURATE wire flag when true. Docs and validation for invalid overflow values are removed accordingly.

Default out-of-bounds behavior no longer raises ResponseError on the client; rejected increments return [current_value, 0] and leave the key (and TTL) unchanged. Tests were renamed/extended for that semantics, including integer type-limit cases with saturate=True on the sync path.

CI runs Redis 8.8 against a custom Debian image instead of 8.8-rc1. Async pub/sub test_late_subscribe calls connect() before run() to avoid a CI race instead of polling for connection readiness.

Reviewed by Cursor Bugbot for commit 8a4a764. Bugbot is set up for automated code reviews on this repo. Configure here.

@petyaslavova petyaslavova added the feature New feature label May 22, 2026
@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 22, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@petyaslavova petyaslavova requested a review from vladvildanov May 22, 2026 12:13
Comment thread tests/test_asyncio/test_commands.py
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3ae9345. Configure here.

Comment thread tests/test_commands.py
@petyaslavova petyaslavova merged commit 30f1f47 into master May 27, 2026
343 checks passed
@petyaslavova petyaslavova deleted the ps_update_increx_args branch May 27, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants