fix: sidebar collapse reactivity, config-merge title fallback, review cleanups#83
Open
redmodd wants to merge 1 commit into
Open
fix: sidebar collapse reactivity, config-merge title fallback, review cleanups#83redmodd wants to merge 1 commit into
redmodd wants to merge 1 commit into
Conversation
… cleanups Sidebar section toggles mutated a plain Set inside $state, which Svelte 5 does not proxy, so collapsing never updated the UI; switched to SvelteSet. The config merge spread userConfig after the defaulted title, so an empty title shipped as "" instead of "Untitled Course", and quiz-mode configs carried a stray percentageThreshold default. Both fixed with new unit tests. Also: dedupe Quiz.svelte's answering/review question list into a snippet, drop the SCORM manifest and extractDefaultExportObjectLiteral wrappers, flatten the CLI's nested switch into a dispatch table, omit empty optional keys from suspend_data, un-$state the App.svelte effect guards, and bump the scaffolded workspace pnpm pin to 11.5.2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs found in a full-codebase review, both covered by new unit tests:
Setinside$state, which Svelte 5 doesn't proxy; now aSvelteSet.titleskipped the "Untitled Course" fallback — the merge spreaduserConfigafter the defaulted title; quiz-mode configs also picked up a straypercentageThresholddefault.Plus small cleanups: Quiz.svelte question-list snippet dedup, removed the SCORM-manifest and
extractDefaultExportObjectLiteralwrappers, CLI dispatch table, empty optional keys omitted from suspend_data, plain-leteffect guards in App.svelte, and the scaffolded-workspace pnpm pin bumped to 11.5.2.Tested: full unit suites (892 + 20) and the complete Playwright e2e suite (105 tests) covering all four modes — SCORM 1.2, SCORM 2004, cmi5, and web.