Skip to content

Proposed v1.0.0 with relaxed lookup#4

Open
coolaj86 wants to merge 4 commits intoregality:masterfrom
coolaj86:master
Open

Proposed v1.0.0 with relaxed lookup#4
coolaj86 wants to merge 4 commits intoregality:masterfrom
coolaj86:master

Conversation

@coolaj86
Copy link
Copy Markdown
Collaborator

To address issue #2 I've added mms address lookup.

Also, lookups are less sensitive. For example, the gateways for "AT&T" can be lookup by the string "AT&T Mobility" or simply "att".

The current functionality still works, but I didn't bother to document it, since it should be deprecated moving forward.

The only things that aren't 100% backwards compatible:

  • I updated some gateway addresses to the current addresses (i.e. the Alaska gateway address seemed old / incorrect)
  • require('sms-address').carriers gives a short name as a key (i.e. "verizon" instead of "Verizon Wireless"), but I can change that back if necessary.

@coolaj86
Copy link
Copy Markdown
Collaborator Author

Also, for legacy purposes I created the file historic.js which contains all the carriers I found online, but none of which my application has yet to encounter.

I've only run about 2,000 numbers through ported number checking so far and all of the carriers that I found in that sample are in the file in-the-wild.js. As I encounter more carriers I'll move them over, but I want to maintain a distinction between companies that were bought out years ago and the ones currently in the wild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant