Open
Conversation
Collaborator
Author
|
Also, for legacy purposes I created the file I've only run about 2,000 numbers through ported number checking so far and all of the carriers that I found in that sample are in the file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address issue #2 I've added mms address lookup.
Also, lookups are less sensitive. For example, the gateways for "AT&T" can be lookup by the string "AT&T Mobility" or simply "att".
The current functionality still works, but I didn't bother to document it, since it should be deprecated moving forward.
The only things that aren't 100% backwards compatible:
require('sms-address').carriersgives a short name as a key (i.e. "verizon" instead of "Verizon Wireless"), but I can change that back if necessary.