Conversation
leburnett
reviewed
May 18, 2026
Collaborator
leburnett
left a comment
There was a problem hiding this comment.
Works well for CT1 and DNc02 and is a good solution. I tried aMe12 because I knew that that was a bilateral cell but, as you mention, this fix is only for cells that predominantly innervate the contralateral side. Capturing the innervation of bilateral cells in both hemispheres is out of the scope of this PR. Merging in now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For neuron types whose contra lateral innervation is larger than the ipsi lateral, it now looks like this:
instead of
Other neurons will also highlight the side for both, the celltype and ROI, in color.
The ROIs will be show in the correct location in the combined page. This also means, the Left cell will show on the "right side", the right cell on the "left side":
Also, the eyemaps for left and right side now have the same size.
This partially addresses #52