fix(v3): clear dirty flag when undo returns to a saved state (v0.19)#88
Merged
Conversation
The undo/redo snapshots captured text + selection but not the `dirty` flag, so undoing the only edit left "● edited" showing even though the document matched what was loaded. Snapshot `dirty` too (pushUndo captures pre-mutation state, so the snapshot records the correct pre-edit value) and restore it in restoreSnapshot. Undo back to the loaded state now clears the indicator; redo re-asserts it; undoing one of several edits keeps it (edits remain). Footer v0.18 → v0.19. npm test green (arena 10 · v2 137 · v3 576); browser-verified the load/edit/undo/redo/partial-undo indicator states. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix flagged during the Variables-panel review.
Bug: undo/redo snapshots captured text + selection but not the
dirtyflag, so undoing the only edit left "● edited" showing even though the document matched what was loaded.Fix: snapshot
dirtytoo (pushUndocaptures pre-mutation state, so it records the correct pre-edit value) and restore it inrestoreSnapshot. Undo back to the loaded state now clears the indicator; redo re-asserts it; undoing one of several edits keeps it (edits remain).Footer v0.18 → v0.19.
npm testgreen (arena 10 · v2 137 · v3 576). Browser-verified load → clean, edit → dirty, undo → clean, redo → dirty, partial-undo → dirty.🤖 Generated with Claude Code