bug: add test to confirm no race exists anymore#312
Merged
Conversation
Contributor
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Mar 25, 2026 9:51p.m. | Review ↗ |
| Shell | |
Mar 25, 2026 9:51p.m. | Review ↗ |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new regression test intended to ensure concurrent configuration creation/reconfiguration no longer triggers the data race described in #204.
Changes:
- Add a concurrent test (
TestNewConfigConcurrent) inconfig_test.go. - Add
syncimport to support the concurrency test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meling
force-pushed
the
meling/204/bug-test-concurrent-newconfig
branch
from
811da43 to
50c7729
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
$ go test -run TestConfigurationExtendConcurrent -race -count=1000 PASS ok github.com/relab/gorums 4.503s
meling
force-pushed
the
meling/204/bug-test-concurrent-newconfig
branch
from
50c7729 to
10d9914
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204