CLOUDDST-28603: Add retry on ErrataClient._call_et#666
Merged
Conversation
JAVGan
requested review from
chandwanitulsi,
rajulkumar and
rbikar
as code owners
Contributor
Author
querti
reviewed
Jul 24, 2025
querti
left a comment
querti
left a comment
Collaborator
There was a problem hiding this comment.
LGTM other than some minor comments. Though I can't give official approval because I'm not a code owner.
JAVGan
force-pushed
the
errata_client_retry
branch
from
b8bf96b to
30acbd2
Compare
querti
approved these changes
Jul 24, 2025
Contributor
Author
|
@rajulkumar @chandwanitulsi PTAL as well |
JAVGan
force-pushed
the
errata_client_retry
branch
from
30acbd2 to
3d9e7a0
Compare
Contributor
Author
|
@querti @rbikar @chandwanitulsi UPDATE: Just changed the retry function to be anonymous (lambda). I think it fits better the code 😃 See: diff |
midnightercz
approved these changes
Aug 4, 2025
This commit adds a retry on `ErrataClientBase._call_et` in order to re-attempt failed requests with the Errata Tool. Refers to CLOUDDST-28603 Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
JAVGan
force-pushed
the
errata_client_retry
branch
from
3d9e7a0 to
38a5a91
Compare
Contributor
Author
|
@midnightercz I've just rebased and fixed the conflict on |
rbikar
requested changes
Aug 4, 2025
JAVGan
force-pushed
the
errata_client_retry
branch
2 times, most recently
from
3476021 to
2efa353
Compare
This commit updates the `errata_client` module to use the retry mechanism from `requests` library during the `_errata_service` session definition. Refers to CLOUDDST-28603 Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
JAVGan
force-pushed
the
errata_client_retry
branch
from
2efa353 to
36d308f
Compare
rbikar
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a retry on
ErrataClientBase._call_etin order to re-attempt failed requests with the Errata Tool.Refers to CLOUDDST-28603