Skip to content

Fix Windows installer cleanup and update connectd version #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieRuderman merged 2 commits into from
Mar 24, 2026
Merged

Fix Windows installer cleanup and update connectd version #1053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
992dc17
fix(electron): harden windows installer cleanup
JamieRuderman Mar 24, 2026
d6f8ee0
chore(electron): update connectd version
JamieRuderman Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions electron/installer.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Var FileHandle

; Install new agent
FileWrite $FileHandle "Installing Agent ... $\r$\n"
!insertmacro logExec "$\"$INSTDIR\resources\remoteit$\" agent install"
!insertmacro logExecRequired "$\"$INSTDIR\resources\remoteit$\" agent install" "The Remote.It agent service could not be installed. Setup will now exit."

; REMOVE AFTER v3.16.x -- Remove from machine path env var incase already there
FileWrite $FileHandle "Cleaning up old PATH ... $\r$\n"
Expand Down Expand Up @@ -89,11 +89,11 @@ Var FileHandle
${else}
FileWrite $FileHandle "Uninstalling...$\r$\n"

IfFileExists "$APPDATA\remoteit\config.json" config_found config_not_found
IfFileExists "$COMMONAPPDATA\remoteit\config.json" config_found config_not_found
config_found:
FileWrite $FileHandle "Config found$\r$\n"

!insertmacro logPowershell "(Get-Content -Raw -Path $APPDATA\remoteit\config.json | ConvertFrom-Json).device.uid.length"
!insertmacro logPowershell "(Get-Content -Raw -Path '$COMMONAPPDATA\remoteit\config.json' | ConvertFrom-Json).device.uid.length"

IntCmp $1 0 notDevice notDevice thereIsDevice
notDevice:
Expand Down Expand Up @@ -135,6 +135,7 @@ Var FileHandle

; Remove from path env var
!insertmacro logPowershell "[Environment]::SetEnvironmentVariable('PATH', (([Environment]::GetEnvironmentVariable('PATH', 'Machine')).Split(';') | Where-Object { ($$_ -notlike '*\${PRODUCT_FILENAME}*') -and ($$_ -ne '') }) -join ';', 'Machine')"
!insertmacro logPowershell "[Environment]::SetEnvironmentVariable('PATH', (([Environment]::GetEnvironmentVariable('PATH', 'User')).Split(';') | Where-Object { ($$_ -notlike '*\${PRODUCT_FILENAME}*') -and ($$_ -ne '') }) -join ';', 'User')"

; Remove files
FileWrite $FileHandle "$\r$\nRemoving installation directories... $\r$\n"
Expand Down Expand Up @@ -194,6 +195,16 @@ Var FileHandle
FileWrite $FileHandle "Result Output: $1$\r$\n"
!macroend

!macro logExecRequired command errorMessage
!insertmacro logExec "${command}"
${If} $0 != 0
FileWrite $FileHandle "Fatal installer error: ${errorMessage}$\r$\n"
FileClose $FileHandle
MessageBox MB_OK|MB_ICONSTOP "${errorMessage}"
Abort
${EndIf}
!macroend

!macro openLogFile section
IfFileExists "$TEMP\${LOGNAME}" logFound logNotFound
logFound:
Expand Down
2 changes: 1 addition & 1 deletion electron/src/backend/binary-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cli": "4.1.0",
"connectd": "5.5.0",
"connectd": "5.5.1",
"muxer": "0.10.0",
"demuxer": "0.10.0",
"cliUrl": "https://downloads.remote.it/cli/v",
Expand Down
Loading