Skip to content

Update to supported versions#56

Open
stephanvierkant wants to merge 3 commits intoremotelyliving:masterfrom
stephanvierkant:update-symfony
Open

Update to supported versions#56
stephanvierkant wants to merge 3 commits intoremotelyliving:masterfrom
stephanvierkant:update-symfony

Conversation

@stephanvierkant
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7742771606

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 99.856%

Files with Coverage Reduction New Missed Lines %
src/Entities/DataAbstract.php 1 97.22%
Totals Coverage Status
Change from base Build 1981427975: -0.1%
Covered Lines: 694
Relevant Lines: 695

💛 - Coveralls

Copilot AI review requested due to automatic review settings February 5, 2026 09:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependency version constraints to support newer versions of key dependencies.

Changes:

  • Adds support for psr/cache ^3.0
  • Updates symfony/event-dispatcher to support versions ^8.0, ^7.4, and ^6.4 (removing support for older versions)
  • Updates symfony/cache to support versions ^8.0, ^7.4, and ^6.4 (removing support for ^4.3)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"psr/cache": "^1.0 || ^2.0",
"symfony/event-dispatcher": "^6.0 || ^5.0 || ^4.0 || ^3.0",
"psr/cache": "^1.0 || ^2.0 || ^3.0",
"symfony/event-dispatcher": "^8.0 || ^7.4 || ^6.4",
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint ^8.0 || ^7.4 || ^6.4 for symfony/event-dispatcher is incompatible with the current codebase. The code extends Symfony\Component\EventDispatcher\GenericEvent (see src/Observability/Events/ObservableEventAbstract.php:7-9), which was deprecated in Symfony 6.1 and removed in Symfony 7.0. This means the code will not work with Symfony 7.x or 8.x versions. Before updating to these versions, the codebase needs to be refactored to stop using GenericEvent and use the Event class from symfony/contracts instead.

Suggested change
"symfony/event-dispatcher": "^8.0 || ^7.4 || ^6.4",
"symfony/event-dispatcher": "^6.4",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants