Added support for adding, deleting and listing share links#17
Open
cniccolo wants to merge 1 commit intorenber:masterfrom
Open
Added support for adding, deleting and listing share links#17cniccolo wants to merge 1 commit intorenber:masterfrom
cniccolo wants to merge 1 commit intorenber:masterfrom
Conversation
| public override async Task<bool> ParseResponseAsync(System.Net.Http.HttpResponseMessage msg) | ||
| { | ||
| string content = await msg.Content.ReadAsStringAsync(); | ||
| return content == "\"success\""; |
There was a problem hiding this comment.
Restarting a dead project here: the response returned from seafile is a JSON object with a single "success" boolean property.
https://download.seafile.com/published/web-api/v2.1/share-links.md#user-content-Delete%20Share%20Link
{"success":true}
Owner
There was a problem hiding this comment.
Thanks for contributing. The library is not really dead in the actual sense as I am using it daily in production. However, all the features which are needed there have been implemented already and I lack time to continue development for other parts of the API.
So, any help is much appreciated :)
I will check your review and hopefully this merge request can finally find its way into the library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.