Skip to content

Angular update#781

Open
jma wants to merge 28 commits into
rero:stagingfrom
jma:angular-update
Open

Angular update#781
jma wants to merge 28 commits into
rero:stagingfrom
jma:angular-update

Conversation

@jma
Copy link
Copy Markdown
Contributor

@jma jma commented Feb 16, 2026

No description provided.

@jma jma force-pushed the angular-update branch 5 times, most recently from 53e2aa6 to 832bec9 Compare February 19, 2026 13:12
@jma jma force-pushed the angular-update branch 15 times, most recently from e4e7134 to 23bb247 Compare March 5, 2026 15:59
@jma jma force-pushed the angular-update branch 7 times, most recently from b04161f to 6a8aabb Compare March 10, 2026 15:30
@jma jma marked this pull request as ready for review March 10, 2026 15:31
@jma jma requested a review from PascalRepond March 10, 2026 15:31
* Fixes deprecated on can desactivate compoenent.
* Fixes typo on file name and changes import.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@jma jma force-pushed the angular-update branch from 69ec629 to 5b8a2d7 Compare March 25, 2026 13:01
- Remove zone.js from angular.json polyfills
- Remove zone.js import from polyfills.ts
- Replace provideZoneChangeDetection with provideZonelessChangeDetection in main.ts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jma jma force-pushed the angular-update branch from 5b8a2d7 to d1b9bb6 Compare March 25, 2026 13:41
jma and others added 19 commits March 31, 2026 09:10
…ord type configuration

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nts and fix sync pipes

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the early-return guard that blocked suggestions when recordPid
is null. On /new routes there is no pid in route params, causing all
autocomplete fields to return empty results. Remote services already
handle null currentPid gracefully (they simply omit the NOT pid: filter).

Update IRemoteAutocomplete interface and base service to accept
string | null for currentPid.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tion properties

- Replace `any` with `number` for `bucketSize` in `Aggregation` interface
- Replace `any` with `JsonObject` in `enrichAggregation` method signature
- Copy additional/unknown ES aggregation properties to the enriched aggregation

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… re-render

Reading from activatedRoute.snapshot (non-reactive) prevented the toggle
switch UI from updating after filter changes in zoneless/OnPush mode.
isChecked now reads store.aggregationsFilters() so Angular tracks the
signal and re-renders automatically.

Also ignores AI tool working directories (.claude, .cursor, etc.) in .gitignore.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…wEmptySearch is false

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…eNG styles

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…th memoization

- Add Observable-based processBucketName and processFilterName to RecordType
- Update Bucket interface with aggregationKey, name and label$ Observable
- Remove BucketNamePipe and migrate to Observable pattern for dynamic translation
- Implement memoization in ListFiltersComponent to prevent re-subscription
- Add enrichedBuckets computed property for label$ enrichment
- Update all aggregation components to use async pipe for Observable labels
- Fix type compatibility issues (null -> undefined in p-button)
- Update test fixtures with new Bucket structure
- Export IFilter interface in record-search.interface
- Standardize imports and minor code organization
…utton

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…essage is not configured

DEFAULT_RECORD_TYPE had deleteMessage set to () => [], which caused the confirmation
modal to display with an empty message. Setting it to null lets record-ui.service fall
back to defaultDeleteMessage() as intended.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…sions check

canDelete/canUpdate/canRead/canUse were set to () => of({ can: true }) in
DEFAULT_RECORD_TYPE, causing the store's canDeleteRecord$() to always return
true instead of falling through to config.permissions(). Setting them to null
lets the store reach the permissions() branch when no explicit handler is defined.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ord$

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds aggregationNameFromConfig() to the store to resolve display names
from the aggregationsName config map, and updates the aggregation template
to prefer config-defined names over raw keys. Changes store visibility to
protected to allow template access.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…layer

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… defined

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jma and others added 6 commits May 12, 2026 08:41
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Initialize locale data in NgCoreTranslateService constructor instead of
a separate initialize() method, removing the need for provideEnvironmentInitializer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Enable isolatedModules for esbuild compatibility
- Remove View Engine options (skipTemplateCodegen, strictMetadataEmit)
- Remove invalid typeRoots pointing to a file instead of a directory
- Delete legacy SystemJS typings.d.ts (unused)
- Alias Error import to CoreError in record.service to avoid global conflict

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Alias Error import to CoreError in record.service.spec to avoid
  conflict with global Error under isolatedModules
- Remove service.initialize() calls now handled by constructor

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants