Add overflow hidden to the role list under server settings.#5
Open
fearganni wants to merge 2 commits intorevoltchat:masterfrom
Open
Add overflow hidden to the role list under server settings.#5fearganni wants to merge 2 commits intorevoltchat:masterfrom
fearganni wants to merge 2 commits intorevoltchat:masterfrom
Conversation
Issue where the role name extends out of the button item. - overflow: 'hidden', takes away the access characters from overlapping over the role permission section. - title, shows the fill role name on hover of the item. (tested text wrapping but doesn't look good at all, overflow hidden is much cleaner).
Update RoleList.tsx (Fix role name extending out of the button)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it so that the text within the role list button doesn't overflow ontop of the permission side. I also added a title so that when the button is hovered it displays the whole role text.
Please make sure to check the following tasks before opening and submitting a PR
From this:
To this:
