feat(MultiFactor): remove registry dependency#33
Open
zeroknots wants to merge 2 commits into
Open
Conversation
Drops ERC7484RegistryAdapter inheritance and the subvalidator attestation checks in onInstall/setValidator so the module no longer requires a registry at construction or use. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds onlyBuiltDependencies entries so pnpm install succeeds without manual approval for git-hosted Rhinestone packages. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![rhinestone-kevin[bot]](https://avatars.githubusercontent.com/in/3714871?s=60&v=4){kind=small}
| uint256 iteration => mapping(address subValidator => IterativeSubvalidatorRecord record) | ||
| ) internal iterationToSubValidator; | ||
|
|
||
| constructor(IERC7484 _registry) ERC7484RegistryAdapter(_registry) { } |
There was a problem hiding this comment.
blocker — Removing the only constructor makes MultiFactor a no-arg contract, but test/MultiFactor/unit/concrete/MultiFactor.t.sol:46 and test/MultiFactor/integration/concrete/MultiFactor.t.sol:44 still instantiate new MultiFactor(...) with a registry argument. That leaves the PR in a non-compiling state once the MultiFactor suites are built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the ERC-7484 registry dependency from
MultiFactor. DropsERC7484RegistryAdapterinheritance, theIERC7484constructor argument, and theREGISTRY.checkForAccountattestation checks inonInstallandsetValidator. The module can now be deployed and used without a registry.Test plan
MultiFactortest constructors to drop the registry argumentforge testagainst the MultiFactor suites