fix: allow private/loopback hosts for local Hermes connections#30
Merged
Conversation
Drops the SSRF guard (assertHostnameIsPublic + ipIsPrivateOrLocal) that rejected RFC1918, loopback, link-local, and other reserved addresses during the /v1/models discovery fetch. Infinite-Loop runs as a single-tenant local app, so the typical Hermes target is a LAN or localhost server (e.g. http://192.168.x.x) — the guard blocked the intended path with no real benefit in this deployment model. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assertHostnameIsPublic+ipIsPrivateOrLocal) that rejected RFC1918, loopback, link-local, and other reserved addresses before the/v1/modelsdiscovery fetch inlib/server/providers/hermes-local-store.ts.http://192.168.x.x), which the guard blocked with no real benefit in this deployment model.http://192.168.2.61no longer fail withrefusing to reach private/loopback address …when creating a Hermes connection.Test plan
192.168.x.xhost and confirm save succeeds and per-portprofilediscovery runs.http://127.0.0.1/http://localhostand confirm save succeeds.npx tsc --noEmitis clean.🤖 Generated with Claude Code