add can fd support to can transport layer #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Cheers for this. I'll have a review and get it in this week. |
Author
|
Any news about your review? |
richClubb
reviewed
Oct 28, 2020
Comment on lines
282
to
290
|
|
||
| sleep(0.001) | ||
| #sleep(0.01) | ||
|
|
Owner
There was a problem hiding this comment.
Why has this been changed? Is it important? The sleep was in to mitigate intermittent issues with CanTp correctly processing the responses
richClubb
reviewed
Oct 28, 2020
Comment on lines
+1
to
+5
| include uds/uds_configuration/defaultConfig.ini | ||
| include uds/uds_communications/Uds/config.ini | ||
| include uds/uds_communications/TransportProtocols/config.ini | ||
| include uds/uds_communications/TransportProtocols/Can/config.ini | ||
| include uds/uds_communications/TransportProtocols/Lin/config.ini |
Owner
There was a problem hiding this comment.
Did you change this manually? Or was it automatic?
richClubb
reviewed
Oct 28, 2020
…ed on data bit length instead of integer type. - Negative response returns dictionary with NRC value instead of throwing exception. - Set can message dlc to its length (the bus DLC is already handled in python-can). - Update unit tests for the function containers.
- Correct bug for external can vector bus connection.
Refactored CanTp.py and UdsConfigTool.py for usage of uds auxiliary
…an-uds Revert "Refactored CanTp.py and UdsConfigTool.py for usage of uds auxiliary"
* Refactored CanTp.py and UdsConfigTool.py for usage of uds auxiliary * add parametrized wait time to iso tp/uds send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.