Feature Query String Matcher Comparisons#138
Closed
pbolduc wants to merge 1 commit intorichardszalay:masterfrom
Closed
Feature Query String Matcher Comparisons#138pbolduc wants to merge 1 commit intorichardszalay:masterfrom
pbolduc wants to merge 1 commit intorichardszalay:masterfrom
Conversation
724544b to
e622845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is initial version of being able to add string comparisons for query strings. It is to address #134. There is still more work that will need to be done before this should be merged. Additional unit tests and examples should be added as well. I still need to add optional parameters to the extension methods. Please consider this PR as draft. I would appreciate any feedback on the design and any changes you would like to see.
Example
Proposed extension method change:
Usage
QueryStringMatcherOptions