doc: Explain behaviour of when/expect#153
Open
timabell wants to merge 2 commits intorichardszalay:masterfrom
Open
doc: Explain behaviour of when/expect#153timabell wants to merge 2 commits intorichardszalay:masterfrom
timabell wants to merge 2 commits intorichardszalay:masterfrom
Conversation
I found the behaviour of when/expect confusing, and couldn't see how to set the "always" behaviour. This patch adds a bit more clarity to that area of usage to the readme.
This took me hours to figure out.
Owner
|
Apologies for the delayed reply on this, but isn't this effectively duplicating the "Match Behavior" section of the readme? |
Author
|
Well, technically yes, but let me put it this way, I think I spent about 2 or 3 hours scratching my head why I wasn't getting a mock to hit when it was defined even after reading the existing docs. This proposed addition is how I would have liked it explained to me to be able get the mental model I needed to understand why the sequence of mocks behave as they do with the combinations of when / expect and the configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the behaviour of when/expect confusing, and couldn't see how to set the "always" behaviour. This patch adds a bit more clarity to that area of usage to the readme.
Hopefully I've the updated description of the behaviour is accurate, I've not used this library much.
Thanks for the library, solves a painful problem.