only import mac dependencies if OsD.IsMacos()#115
Open
lockenkop wants to merge 4 commits intorichibrics:mainfrom
Open
only import mac dependencies if OsD.IsMacos()#115lockenkop wants to merge 4 commits intorichibrics:mainfrom
lockenkop wants to merge 4 commits intorichibrics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone before me stumbled upon this MacOS dependecy import that always raises an exception on every other OS. The MyPy ignores don’t work in my dev env (vscode, debugpy which uses #@IgnoreException).
Sadly i did not find a way to configure debugpys ignore exception tags
https://github.com/microsoft/debugpy/blob/514e54fa2b87951e571ac5b6596c461f6644432a/src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_frame.py#L51
If this change is breaking something else, i’d be happy to just add #@IgnoreException
I'll test this on windows tomorrow, i can't test it on macos myself.