Skip to content

SmartCircuits new API#36

Open
jkt628 wants to merge 3 commits intoricho:mainfrom
jkt628:smartSwitch-new-API
Open

SmartCircuits new API#36
jkt628 wants to merge 3 commits intoricho:mainfrom
jkt628:smartSwitch-new-API

Conversation

@jkt628
Copy link
Copy Markdown
Contributor

@jkt628 jkt628 commented Apr 5, 2026

fixes #35

@richo
Copy link
Copy Markdown
Owner

richo commented Apr 5, 2026

Thankyou! I will try to have a look and test it today. I am pretty sus of 6cba9da, and might rebase around it.

I totally see what you're driving at with it, but the fact that the cache never purges, as well as the fact that it makes reasoning about what the integration actually sees makes me pretty skeptical. As a concrete example, it seems that sometimes they just return an empty body and if that winds up in the cache I think the whole integration will wedge itself.

@jkt628 jkt628 force-pushed the smartSwitch-new-API branch from 916bde9 to 4c9fe99 Compare April 5, 2026 15:56
@richo
Copy link
Copy Markdown
Owner

richo commented Apr 5, 2026

Oh thankyou! I was happy to go around it, but appreciate you rebasing :)

@jkt628
Copy link
Copy Markdown
Contributor Author

jkt628 commented Apr 5, 2026

Thankyou! I will try to have a look and test it today. I am pretty sus of 6cba9da, and might rebase around it.

I totally see what you're driving at with it, but the fact that the cache never purges, as well as the fact that it makes reasoning about what the integration actually sees makes me pretty skeptical. As a concrete example, it seems that sometimes they just return an empty body and if that winds up in the cache I think the whole integration will wedge itself.

this is intended only for periodic calls and the cache purges every time its API is invoked, for any client including dead and gone. i can tell you from experience it makes a big difference in HTTP traffic, especially with async.

@jkt628
Copy link
Copy Markdown
Contributor Author

jkt628 commented Apr 5, 2026

I am pretty sus

what is "sus"???

@jkt628 jkt628 force-pushed the smartSwitch-new-API branch from 4c9fe99 to efdbfcf Compare April 7, 2026 11:31
@jkt628
Copy link
Copy Markdown
Contributor Author

jkt628 commented Apr 7, 2026

fixed statistics

@jkt628 jkt628 force-pushed the smartSwitch-new-API branch 3 times, most recently from bb2d7d4 to f49551d Compare April 8, 2026 11:52
@jkt628 jkt628 force-pushed the smartSwitch-new-API branch from f49551d to 4f73421 Compare April 8, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SmartCircuit new API

2 participants