Skip to content

Improve CMake Scripts Composing#749

Open
WhiredPlanck wants to merge 10 commits into
rime:masterfrom
WhiredPlanck:cmake
Open

Improve CMake Scripts Composing#749
WhiredPlanck wants to merge 10 commits into
rime:masterfrom
WhiredPlanck:cmake

Conversation

@WhiredPlanck

Copy link
Copy Markdown
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #N/A

Feature

Describe feature of pull request

Improve CMake scripts composing

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Also change the condition: only not to install on Android since Android doesn't support pkgconfig yet.
Also rename option BUILD_STATIC to WITH_STATIC_DEPS to make people more aware of its role
@WhiredPlanck WhiredPlanck force-pushed the cmake branch 4 times, most recently from d8aa71b to b5d4a0c Compare October 30, 2023 12:51
@ghostflyby

Copy link
Copy Markdown

Is this still active?

@ghostflyby ghostflyby mentioned this pull request Jan 19, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants