Skip to content

feat: add PIV and YubiKey hardware backends #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lomigmegard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add PIV and YubiKey hardware backends #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- name: Install system libraries
run: sudo apt-get update && sudo apt-get install -y libssl-dev
run: sudo apt-get update && sudo apt-get install -y libssl-dev libpcsclite-dev
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
with:
components: rustfmt, clippy
Expand All @@ -28,18 +28,25 @@ jobs:
run: cargo fmt --all -- --check
- name: Clippy
run: cargo clippy --workspace --all-targets -- -D warnings
# The default workspace build leaves the hardware-backend features off, so
# lint the piv/yubikey code paths and their tests explicitly.
- name: Clippy (hardware backends)
run: cargo clippy -p rite-stdlib --features piv,yubikey --all-targets -- -D warnings

test:
name: Test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
- name: Install system libraries
run: sudo apt-get update && sudo apt-get install -y libssl-dev
run: sudo apt-get update && sudo apt-get install -y libssl-dev libpcsclite-dev
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
- name: Test
run: cargo test --workspace
# piv/yubikey are off by default; run their action and backend tests.
- name: Test (hardware backends)
run: cargo test -p rite-stdlib --features piv,yubikey

msrv:
# Verifies the MSRV floor declared on the library crates that are
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ jobs:
key: release-${{ matrix.rust_target }}

- name: Build rite
run: cargo build --release -p rite --target ${{ matrix.rust_target }} --features openssl-vendored
# PC/SC is a system framework on macOS (PCSC.framework) and Windows
# (WinSCard), so the native release binaries carry the piv/yubikey
# backends. Only the static musl Linux tarballs stay software-only.
run: cargo build --release -p rite --target ${{ matrix.rust_target }} --features openssl-vendored,piv,yubikey

- name: Build rite-ls
run: cargo build --release -p rite-ls --target ${{ matrix.rust_target }}
Expand Down Expand Up @@ -104,6 +107,13 @@ jobs:
steps:
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0

# The glibc `image` target compiles the arm64 binary under emulation, so
# register QEMU binfmt explicitly rather than relying on the runner's
# preinstalled handlers. The musl `binaries-*` targets cross-compile and
# do not need it.
- name: Set up QEMU
uses: docker/setup-qemu-action@06116385d9baf250c9f4dcb4858b16962ea869c3 # v4.1.0

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5 # v4.1.0

Expand Down
Loading