Icarus' Song Tweak#318
Open
r0bd0g wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I should have thought of redoing the keys separation to see if I could get a closer listen back when we reviewed this earlier this year. Anyway, what I thought were unique chords in m91 and m111 seem to just be some especially loud left hand hits, so I removed those chords from the playable parts and RH anim. The same thing occurs in m107 but I didn't notice anything there before, so while the playable parts were correct in that measure, I needed to update the LH anim to include it. (I think the guidelines for venues have changed between then and now, but I didn't make any changes to the venue.)