fix: calculation: guide typo + king placement onto foundation#8
Open
Magicrafter13 wants to merge 2 commits into
Open
fix: calculation: guide typo + king placement onto foundation#8Magicrafter13 wants to merge 2 commits into
Magicrafter13 wants to merge 2 commits into
Conversation
get to the end of any foundation and the game was expecting an ace as the next card...
Author
|
also I have NO idea what your lua compilation process is... I compiled the fnl files, but then had to manually edit them (joining, adding lines, renaming variables) to make the diffs nice. might be worth documenting your process in the README |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: the game still cannot be completed. My best understanding (via AI) is that the code is checking for sequential cards in each foundation (1,2,3,4,5,etc) instead of following the game's stacking rules, and is ALSO checking that all the suits in a foundation are the same.
Personally I would just make the logic check that all 4 foundations have a king on top, since, assuming the game's placement logic holds, that should be sufficient?
Regardless, I don't remotely comprehend Fennel (I barely know Lua), and I could not be fully assured that the output from GPT was trivial and non-copyright-infringing, so I have not committed the fix it generated for that issue (it didn't work anyway lol). Hopefully this PR can bring the broken win condition to someone's attention.
The actual changes I'm submitting here are largely trivial. The guide was printed wrong for foundation 2 (7+2=9), and when trying to place a king on any foundation the game would say "Foundation wants a 1", and with some help I found what seemed to be the culprit, and changed the 1 to a 13. This fixed the issue and I did not find any regressions.