Fix Runtime.callFunctionOn timeout for large files#31
Open
reun100e wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix: Runtime.callFunctionOn timeouts on large documents
Description
When downloading large or complex documents with many pages, the
npm startcommand fails with the following error:ProtocolError: Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.Cause
Newer versions of Puppeteer enforce a default timeout for the Chrome DevTools Protocol (
protocolTimeout), usually set to 180 seconds. InScribdDownloader.js, thepage.evaluatestep slowly scrolls to the bottom to lazy-load the entire document. For large books, this process takes significantly longer than the default timeout, causing it to crash before the render is finished.Solution
This PR updates the
puppeteer.launchoptions insidesrc/utils/request/PuppeteerSg.jsto explicitly setprotocolTimeout: 0. This instructs the engine to wait indefinitely for the evaluation script to finish running, which natively matches thetimeout: 0setting that is already present for page navigation.Testing
Tested locally with a large ~350 page textbook limit and successfully generated and merged the PDF without timeout interruptions.