Use org-mode's built-in emphasis hiding instead of manual overlays#49
Open
jonathanchu wants to merge 1 commit intorlister:masterfrom
Open
Use org-mode's built-in emphasis hiding instead of manual overlays#49jonathanchu wants to merge 1 commit intorlister:masterfrom
jonathanchu wants to merge 1 commit intorlister:masterfrom
Conversation
The custom overlay approach using org-emph-re incorrectly matches + characters in org table separators. Delegate to org-hide-emphasis-markers which is context-aware and handles tables, code blocks, etc. correctly. Fixes rlister#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom overlay approach using
org-emph-reincorrectly matches+characters in org table separators. Instead, useorg-hide-emphasis-markerswhich is context-aware and handles tables, code blocks, etc. correctly. This change is based off the comments from #12.