Multithreaded parallel downloads with auto-scroll and queue UI controls#1885
Open
SirBiggin wants to merge 5 commits into
Open
Multithreaded parallel downloads with auto-scroll and queue UI controls#1885SirBiggin wants to merge 5 commits into
SirBiggin wants to merge 5 commits into
Conversation
# Conflicts: # Source/LibationUiBase/ProcessQueue/ProcessQueueViewModel.cs
…l downloads Snapshot GetVisible() on the UI thread before handing off to Task.Run, preventing InvalidOperationException when parallel downloads modify the collection concurrently. Also fix installer script to use 64-bit dotnet. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HashSet<Task>loop allowing dynamic concurrency changes mid-run.ScrollToTopmethod onVirtualFlowControl.Auto-scrollandParallel downloads— alongside the existing Cancel All and DL Limit controls.InvalidOperationExceptioncrash insetLiberatedVisibleMenuItemcaused by enumeratingGetVisible()on a background thread while parallel downloads modified the collection. Collection is now snapshotted on the UI thread before being passed toTask.Run.Currentitem with an_activelist to track multiple simultaneous downloads, while keeping the backward-compatibleCurrentproperty.AutoScrollQueue(bool) andMaxConcurrentDownloads(int) persistent settings.Test plan
Parallel downloadscheckbox off mid-run and confirm it serializesAuto-scrolland confirm queue scrolls/stops scrolling to active itemsInvalidOperationExceptioncrash during parallel downloadsCancel Allcancels all active downloads