Open
Conversation
Use fancy instructions to scan 16, 32, and 64 byte ranges instead of only inspecting a single byte at a time. While this was a lot of fun to do, it turns out to not be as efficient as being clever about avoiding comparisons whenever possible. That is, reading 1/10 bytes is better than reading 10 at once even if they are the same number of instructions. This is because there is overhead in loading the 128 and 256 bit registers and that overhead reduces the gains enough to give us a net speed that is slightly slower.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use fancy instructions to scan 16, 32, and 64 byte ranges instead of
only inspecting a single byte at a time.
While this was a lot of fun to do, it turns out to not be as efficient
as being clever about avoiding comparisons whenever possible. That is,
reading only 1/20 bytes is better than reading 32 at once even if they are
the same number of instructions. This is because there is overhead in
loading the 128 and 256 bit registers and that overhead reduces the
gains enough to give us a net speed that is slightly slower.