Skip to content

Support Symfony 8.0 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 2 commits into from
Dec 14, 2025
Merged

Support Symfony 8.0 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5fc791
Support Symfony 8.0
Nyholm Dec 12, 2025
6a6975f
Make sure we properly support sf80
Nyholm Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions bin/rr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,17 @@ require RR_COMPOSER_INSTALL;

$app = new Symfony\Component\Console\Application('RoadRunner CLI', Version::current());

$app->add(new GetBinaryCommand());
$app->add(new VersionsCommand());
$app->add(new DownloadProtocBinaryCommand());
$app->add(new MakeConfigCommand());
if (method_exists($app, 'addCommand')) {
$app->addCommand(new GetBinaryCommand());
$app->addCommand(new VersionsCommand());
$app->addCommand(new DownloadProtocBinaryCommand());
$app->addCommand(new MakeConfigCommand());
} else {
// For Symfony 7.3 and lower
$app->add(new GetBinaryCommand());
$app->add(new VersionsCommand());
$app->add(new DownloadProtocBinaryCommand());
$app->add(new MakeConfigCommand());
}

$app->run();
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
"composer/semver": "^3.4",
"spiral/roadrunner-worker": "^2 || ^3",
"spiral/tokenizer": "^2.13 || ^3.15",
"symfony/console": "^5.3 || ^6.0 || ^7.0",
"symfony/http-client": "^4.4.51 || ^5.4.49 || ^6.4.17 || ^7.2",
"symfony/yaml": "^5.4.49 || ^6.4.17 || ^7.2"
"symfony/console": "^5.3 || ^6.0 || ^7.0 || ^8.0",
"symfony/http-client": "^4.4.51 || ^5.4.49 || ^6.4.17 || ^7.2 || ^8.0",
"symfony/yaml": "^5.4.49 || ^6.4.17 || ^7.2 || ^8.0"
Comment on lines +37 to +39
Copy link

@coderabbitai coderabbitai bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

Symfony 8.0 minimum PHP version requirement

💡 Result:

Symfony 8.0 requires PHP 8.4.0 or higher. [1][2]

Sources:
[1] Symfony 8.0 Release (symfony.com/releases/8.0).
[2] Symfony 8 overview (symfony.com/8).

🌐 Web query:

Symfony 8.0 PHP compatibility matrix supported versions

💡 Result:

Symfony 8.0 requires PHP 8.4.0 or higher — i.e. PHP >= 8.4 (any later PHP releases are supported so long as they meet that minimum). [1][2]

Sources:

  • Symfony Releases (8.0): Symfony 8.0 — Requires PHP 8.4.0 or higher. [1]
  • Symfony 8 product page / release notes — Requires PHP 8.4 or higher. [2]

Update PHP constraint to support Symfony 8.0 or remove Symfony 8.0 support.

Symfony 8.0 requires PHP 8.4 or higher, but this package declares "php": ">=8.1" (line 32). This creates a compatibility gap—users on PHP 8.1–8.3 can install the package with Symfony 8.0 but will encounter runtime failures.

To properly support Symfony 8.0, either update the PHP minimum version constraint to >=8.4:

-        "php": ">=8.1",
+        "php": ">=8.4",

Or remove the Symfony 8.0 constraint if you want to maintain support for PHP 8.1–8.3:

-        "symfony/console": "^5.3 || ^6.0 || ^7.0 || ^8.0",
-        "symfony/http-client": "^4.4.51 || ^5.4.49 || ^6.4.17 || ^7.2 || ^8.0",
-        "symfony/yaml": "^5.4.49 || ^6.4.17 || ^7.2 || ^8.0"
+        "symfony/console": "^5.3 || ^6.0 || ^7.0",
+        "symfony/http-client": "^4.4.51 || ^5.4.49 || ^6.4.17 || ^7.2",
+        "symfony/yaml": "^5.4.49 || ^6.4.17 || ^7.2"

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In composer.json around lines 32 and 37-39, the package allows PHP ">=8.1" but
lists Symfony 8.0 in the symfony/* constraints (lines 37-39), creating a
compatibility gap because Symfony 8.0 requires PHP >=8.4; fix by either updating
the PHP platform constraint to ">=8.4" (adjust line 32) to legitimately support
Symfony 8.0, or remove the "|| ^8.0" alternatives from the symfony/console,
symfony/http-client and symfony/yaml constraints (lines 37-39) to keep PHP >=8.1
support without claiming Symfony 8 compatibility.

},
"require-dev": {
"jetbrains/phpstorm-attributes": "^1.2",
Expand Down
Loading